chore: add free-disk-space steps to some github actions - #586
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThree CI workflows add an early disk-cleanup step using ChangesCI runner disk cleanup
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/ci.yml (1)
112-119: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winConsider enabling
remove_tool_cachehere too.The inline comment notes this job has the largest cargo target dir of any Linux job, yet this step omits
remove_tool_cache: truewhile the siblingclippyandtestjobs (lines 46-49, 65-68) both enable it. The tool cache (/opt/hostedtoolcache) is ~14 GB, so reclaiming it would give the disk-heaviest job the most headroom. This job has nodtolnay/rust-toolchainstep, so verify the build still resolves a Rust toolchain from~/.rustup/~/.cargo(unaffected by the tool-cache cleanup) before enabling it.♻️ Optional: reclaim the tool cache for the disk-heaviest job
with: remove_android: true remove_dotnet: true remove_haskell: true + remove_tool_cache: true🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/ci.yml around lines 112 - 119, Enable tool cache cleanup in the Free Disk Space step for the disk-heaviest CI job by adding remove_tool_cache: true to the endersonmenezes/free-disk-space@v3 configuration. Use the existing clippy and test jobs as the reference pattern, and verify this job still builds correctly without dtolnay/rust-toolchain because it should continue resolving Rust from ~/.rustup and ~/.cargo.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.github/workflows/ci.yml:
- Around line 112-119: Enable tool cache cleanup in the Free Disk Space step for
the disk-heaviest CI job by adding remove_tool_cache: true to the
endersonmenezes/free-disk-space@v3 configuration. Use the existing clippy and
test jobs as the reference pattern, and verify this job still builds correctly
without dtolnay/rust-toolchain because it should continue resolving Rust from
~/.rustup and ~/.cargo.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a60f4f6f-f2dc-4d3b-ba8a-7e9807e424de
📒 Files selected for processing (3)
.github/workflows/ci-linux-kvm.yml.github/workflows/ci-netns.yml.github/workflows/ci.yml
84ec1cc to
664a505
Compare
We were running out of disk space in some CI workflows (see https://github.com/gominimal/minimal/actions/runs/28251278261/job/83703128010?pr=584). We have been using endersonmenezes/free-disk-space to free this in some other instances, so I've added it to a few other good candidates for it as well.
Summary by CodeRabbit