You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Working theory is that during link time for the three binaries, its using a ton of memory (as ldd does) and committing death-by-swap.
Splitting the build into different execs for the three binaries should have it link one at a time, and hopefully finish this time. Also bumped up the timeout so we get some more signal before it times out.
Summary by CodeRabbit
Chores
Improved the Linux arm64 release pipeline to run longer and handle builds in smaller stages.
Split release artifact creation into separate steps, which should make builds more reliable and easier to recover if one step fails.
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 693ce188-814a-404c-a86c-273f418722c5
📥 Commits
Reviewing files that changed from the base of the PR and between aff9187 and 0df9ec3.
📒 Files selected for processing (1)
.github/workflows/ci.yml
📝 Walkthrough
Walkthrough
The CI workflow's build-release-linux-arm64 job timeout was increased from 60 to 90 minutes, and the arm64 static release build was refactored from a single combined build/upload of mip, minimal, and minimald into separate build and upload steps per binary.
Changes
ARM64 Release Build Update
Layer / File(s)
Summary
Timeout increase and split build/upload steps .github/workflows/ci.yml
Job timeout raised to 90 minutes; arm64 static build split into separate steps that build and upload minimal, then mip, then begin building minimald.
gominimal/minimal#442: Modifies the same build-release-arm64 job's timeout and build steps in .github/workflows/ci.yml.
Poem
A rabbit watches builds run late,
Ninety minutes now, we patiently wait 🕐
Minimal, mip, minimald in a row,
Each gets its own step, its own artifact glow ✨
Hop along, CI, steady and slow!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working theory is that during link time for the three binaries, its using a ton of memory (as ldd does) and committing death-by-swap.
Splitting the build into different execs for the three binaries should have it link one at a time, and hopefully finish this time. Also bumped up the timeout so we get some more signal before it times out.
Summary by CodeRabbit