feat(installer): implement uninstall, fix update components on MacOS - #663

scripts/install.sh (1)

379-388: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Consider a shared helper for the record row format.

The 4-column tab-delimited printf used to write a record row is duplicated at the skip path (388) and the fresh-install path (428). This format is the uninstaller's sole contract (R7.3/R7.4), so keeping both writers in sync matters; a small helper removes the duplication risk.

♻️ Proposed refactor

+write_record() {
+    printf '%s\t%s\t%s\t%s\n' "$1" "$2" "$3" "$4" >>"$records"
+}
+
 ...
-            printf '%s\t%s\t%s\t%s\n' "$comp" "$target_file" "$want" "$on_disk" >>"$records"
+            write_record "$comp" "$target_file" "$want" "$on_disk"
 ...
-    printf '%s\t%s\t%s\t%s\n' "$comp" "$target_file" "$want" "$(sha256 "$target_file")" >>"$records"
+    write_record "$comp" "$target_file" "$want" "$(sha256 "$target_file")"

Also applies to: 425-428

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@scripts/install.sh` around lines 379 - 388, The 4-column tab-delimited record
row format is duplicated between the skip path and the fresh-install path, so
centralize it behind a shared helper in scripts/install.sh. Add a small helper
used by the existing up-to-date branch and the install branch to emit the record
row, keeping the uninstaller contract consistent and preventing the two `printf`
call sites from drifting out of sync.

scripts/install_test.sh (1)

429-440: 🗄️ Data Integrity & Integration | 🔵 Trivial | ⚡ Quick win

Missing coverage for --purge combined with a kept (unremoved) entry.

All purge scenarios here (u5_plain/u5_purge) have a fully-clean footprint (no modified/foreign files), so they don't exercise the case where kept_modified/kept_foreign > 0 and --purge is also passed — exactly the scenario in the scripts/install.sh do_uninstall review comment where the retained install record gets wiped by the purge step. Worth adding a scenario: seed an install, replace a recorded bin file with a directory (foreign) or leave a modified file with --force omitted, then run --uninstall --purge, and assert the record's fate matches intended behavior once the fix above lands.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@scripts/install_test.sh` around lines 429 - 440, Add coverage for the
`--uninstall --purge` path when some install-record entries are intentionally
kept, since the current `u5_plain`/`u5_purge` cases only cover fully clean
trees. In `scripts/install_test.sh`, extend the
`u5_install`/`u5_plain`/`u5_purge` flow with a scenario that introduces a kept
entry such as a modified or foreign `bin` target, then runs `--uninstall
--purge` and asserts the expected record and cache-tree outcome. Reference the
`u5_plain`, `u5_purge`, and `run` helpers so the new test clearly exercises the
`do_uninstall` behavior under kept entries.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes