feat(release): publish a new "nightly" release every day at 2am PST - #679
Conversation
📝 WalkthroughWalkthroughIntroduces a new ChangesNightly Workflow
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant NightlyWorkflow
participant CheckJob
participant ReleaseWorkflow
participant GCSBucket
NightlyWorkflow->>CheckJob: compute SHA
CheckJob->>GCSBucket: check staged manifest exists
GCSBucket-->>CheckJob: exists/not found
CheckJob-->>NightlyWorkflow: should_release output
NightlyWorkflow->>ReleaseWorkflow: workflow_call (if should_release)
ReleaseWorkflow-->>NightlyWorkflow: staged artifacts
NightlyWorkflow->>NightlyWorkflow: promote-nightly runs set-channel.sh
Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
bcc4dc6 to
2a70ffb
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/nightly.yml:
- Around line 71-74: The google-github-actions/auth@v3 step is using a numeric
value for project_id instead of the actual GCP project ID. Update the auth
configuration so project_id contains the string project identifier, and keep the
numeric project number only in workload_identity_provider. Use the existing auth
step fields to locate and correct the value without changing the provider
format.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: e638c910-ab8c-4a69-8bbf-02708f37bc29
📒 Files selected for processing (2)
.github/workflows/nightly.yml.github/workflows/release.yml
At 2am PST, kicks off a workflow that builds a release from
HEADif one does not already exist, before promoting it tonightly.Summary by CodeRabbit
New Features
Bug Fixes