fix(ci): run the path filter only on pull_request events - #706
Merged
Conversation
The changes jobs failed on every push to main since the lanes landed: dorny/paths-filter on a push event diffs locally against event.before, which our shallow (depth-1), credential-free (persist-credentials: false) checkout can neither resolve nor fetch - so the step exits 128 and the lane aggregators go red on main. On pull_request events dorny reads the file list via the API, which is why every PR run was green while main rotted silently (the lanes are still advisory). Gate the filter step to pull_request and flip the downstream conditions to 'not pull_request OR filter matched': pushes to main and manual dispatches now run everything, which is what main wants anyway - main runs write the main-only caches (#703) and provide the soak signal. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe Linux native and KVM workflows now run their build and test lanes for all non- ChangesLinux CI event gating
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
twitchyliquid64
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What / Why
The
changesjobs in the native and KVM lanes failed on every push to main since the lanes landed (three commits: #702's merge, #686, #703's merge), reddening the advisory lane aggregators while every PR run stayed green.Mechanism: on a
pushevent, dorny/paths-filter diffs locally againstevent.before. Our checkouts are shallow (depth 1) — the before-commit isn't a valid object — andpersist-credentials: falsemeans its fetch fallback dies withcould not read Username, so the step exits 128:On
pull_requestevents dorny reads the file list via the API, which is why the bug stayed invisible until main pushes started mattering.Fix
pull_request.github.event_name != 'pull_request' || <filter matched>: pushes to main and manual dispatches run everything.That's the semantics main wants anyway: main runs are what write the main-only caches (#703's
save-ifdiscipline) and provide the soak signal (#687) — path economy is only meaningful on PRs.Notes
changesbefore building) — this PR's merge push completes it, since post-fix main pushes run all lanes.changesjobs it introduces (ci.yml, ci-macos, ci-shell-installer).Verification
pull_requestpath (filter active, lanes triggered by the workflow-file edits).🤖 Generated with Claude Code
Summary by CodeRabbit