feat(sessions): per-loadout follow symlinks setting - #713

crates/sessions/src/core/loadout.rs (1)

382-423: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

Add an end-to-end test for contribute() stamping.

The new tests cover TOML round-trip and the with_follow_symlinks builder, but nothing exercises the actual propagation path: a Loadout with follow_symlinks = Some(v) and at least one patch, calling contribute(), then asserting the resulting Contribution's ProvenancedPatch::follow_symlinks() reflects the override. This is the core new behavior (set_follow_symlinks_on_patches stamping), and it's currently only verified indirectly via enumerate.rs's walker test, which doesn't go through Loadout::contribute.

✅ Suggested additional test

#[test]
fn contribute_stamps_follow_symlinks_override_onto_patches() {
    use crate::core::compose::Composable;
    use crate::core::primitives::PatchDest;

    let patch = Patch::new("a", PatchDest::try_new("a").unwrap());
    let loadout = Loadout::new(LoadoutName::try_new("test").unwrap())
        .with_patch(patch)
        .with_follow_symlinks(true);

    let env: &dyn Fn(&str) -> Result<String, std::env::VarError> =
        &|_| Err(std::env::VarError::NotPresent);
    let contribution = loadout.contribute(env).unwrap();

    assert_eq!(contribution.patches().len(), 1);
    assert_eq!(contribution.patches()[0].follow_symlinks(), Some(true));
}

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@crates/sessions/src/core/loadout.rs` around lines 382 - 423, Add an
end-to-end test near with_follow_symlinks_builder_sets_the_field that constructs
a Loadout with a Patch, applies with_follow_symlinks(true), calls
Loadout::contribute with an environment lookup returning VarError::NotPresent,
and asserts the resulting Contribution contains one patch whose
ProvenancedPatch::follow_symlinks() is Some(true).