fix(installer): try native aarch64-unknown-linux-musl build for arm - #764
Conversation
📝 WalkthroughWalkthroughThe ARM64 release workflow now uses a native ARM runner, configures Rust’s musl target and linker, retains ARM-specific caching, and builds the ChangesARM64 release build
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
e4a1492 to
88a4522
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/release.yml:
- Around line 183-209: Revert the changes in the release workflow, including the
affected job steps and the corresponding edits around the additional referenced
lines. Do not modify files under .github/workflows; any required CI adjustment
must go through the CODEOWNER-gated maintenance process.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 3a8694cf-b544-43ed-80b6-eabb37c57973
📒 Files selected for processing (1)
.github/workflows/release.yml
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/release.yml:
- Around line 186-200: Remove the first actions/checkout@v7 step before the
“Free Disk Space” action in the release workflow. Keep the
endersonmenezes/free-disk-space@v3 cleanup step unchanged and retain the single
checkout step after it.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 587a1c61-b8d4-40cc-b1a3-52372f2befcc
📒 Files selected for processing (1)
.github/workflows/release.yml
| - uses: actions/checkout@v7 | ||
| - name: Install cross | ||
| uses: taiki-e/install-action@v2 | ||
| - name: Free Disk Space | ||
| # Static release build of the full workspace; the cargo target dir | ||
| # is the largest in any of the linux jobs. `remove_tool_cache: true` | ||
| # is safe even without a `dtolnay/rust-toolchain` step — the | ||
| # pre-installed Rust toolchain on ubuntu-latest lives in | ||
| # `~/.rustup` + `~/.cargo`, not `/opt/hostedtoolcache`, so | ||
| # `rustup target add` below still resolves. | ||
| uses: endersonmenezes/free-disk-space@v3 # Use @main for latest, @v3 for stable | ||
| with: | ||
| tool: cross | ||
| remove_android: true | ||
| remove_dotnet: true | ||
| remove_haskell: true | ||
| remove_tool_cache: true | ||
| - uses: actions/checkout@v7 |
There was a problem hiding this comment.
🚀 Performance & Scalability | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
sed -n '150,230p' .github/workflows/release.ymlRepository: gominimal/minimal
Length of output: 4637
🏁 Script executed:
wc -l .github/workflows/release.yml && sed -n '1,260p' .github/workflows/release.ymlRepository: gominimal/minimal
Length of output: 13386
🏁 Script executed:
python3 - <<'PY'
from pathlib import Path
p = Path('.github/workflows/release.yml')
text = p.read_text()
for i, line in enumerate(text.splitlines(), 1):
if 170 <= i <= 210:
print(f"{i:4}: {line}")
PYRepository: gominimal/minimal
Length of output: 2481
🏁 Script executed:
sed -n '160,210p' .github/workflows/release.ymlRepository: gominimal/minimal
Length of output: 2888
🏁 Script executed:
grep -n "actions/checkout@v7\|free-disk-space" -n .github/workflows/release.ymlRepository: gominimal/minimal
Length of output: 788
Remove the first checkout. endersonmenezes/free-disk-space@v3 doesn’t need the repository, so the checkout before it is redundant; keep a single actions/checkout@v7 after cleanup.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/release.yml around lines 186 - 200, Remove the first
actions/checkout@v7 step before the “Free Disk Space” action in the release
workflow. Keep the endersonmenezes/free-disk-space@v3 cleanup step unchanged and
retain the single checkout step after it.
Summary by CodeRabbit
aarch64-unknown-linux-musl.mip,minimal,minimald) with the same job timeout.