fix(minimald): improve logic for scaffolding session minimal.toml - #780
Merged
Conversation
📝 WalkthroughWalkthroughThe temporary mctx scaffolding module and re-export were removed. Missing MFILE handling now uses mfile detection and initializes the project through ChangesMFILE initialization
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Comment |
norrietaylor
approved these changes
Jul 16, 2026
twitchyliquid64
enabled auto-merge (squash)
July 16, 2026 01:42
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/minimald/src/session.rs`:
- Around line 893-902: Update the missing-file initialization branch in the
session method using mfile::File::from_dir and op::InitProject so plan.toml_path
is created with an exclusive no-replace write rather than std::fs::write. Treat
an AlreadyExists error as Ok(()) and propagate other filesystem errors,
preserving the generated plan content when no concurrent upload exists.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 74571909-1494-4abf-bb37-31ade258ff7d
📒 Files selected for processing (3)
crates/mctx/src/lib.rscrates/mctx/src/scaffold.rscrates/minimald/src/session.rs
💤 Files with no reviewable changes (2)
- crates/mctx/src/scaffold.rs
- crates/mctx/src/lib.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
minimal.tomlmin initlogic for creating a defaultminimal.toml