Skip to content

fix(release): fix warning about dirty workspace during arm64 build - #814

Merged
twitchyliquid64 merged 1 commit into
mainfrom
tom/session-inner
Jul 17, 2026
Merged

fix(release): fix warning about dirty workspace during arm64 build#814
twitchyliquid64 merged 1 commit into
mainfrom
tom/session-inner

Conversation

@twitchyliquid64

@twitchyliquid64 twitchyliquid64 commented Jul 17, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Improved the Linux ARM64 release build workflow by performing disk-space cleanup before checking out the repository.
    • Prevented the cleanup step from leaving unintended changes in the checked-out workspace.

@twitchyliquid64
twitchyliquid64 enabled auto-merge (squash) July 17, 2026 19:51
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The ARM64 release workflow now runs disk-space cleanup before repository checkout and updates the step comment to note that the cleanup action modifies its working directory.

Changes

ARM64 release workflow

Layer / File(s) Summary
Run disk cleanup before checkout
.github/workflows/release.yml
Moves the Free Disk Space step before actions/checkout@v7 and updates the related comment.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • gominimal/pkgs#444: Adjusts Free Disk Space workflow placement before checkout or build.

Suggested reviewers: norrietaylor

Poem

I’m a rabbit hopping through the flow,
Cleaning space before checkout’s go.
No dirty paths, no cluttered track,
ARM64 builds can now hop back.
Carrots packed, the release is bright!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the release workflow change to avoid a dirty workspace warning during the arm64 build.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/release.yml:
- Around line 209-221: Do not merge the workflow change without approval from
the CODEOWNER group `@gominimal/minimalists`, as required for the frozen CI layer;
obtain and preserve the required owner review for the release workflow edits.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a847f38b-cea7-44b1-b8da-3a4b601b8233

📥 Commits

Reviewing files that changed from the base of the PR and between 02ea2f4 and 86ce5c3.

📒 Files selected for processing (1)
  • .github/workflows/release.yml

Comment on lines 209 to +221
- name: Free Disk Space
# Static release build of the full workspace; the cargo target dir
# is the largest in any of the linux jobs. `remove_tool_cache: true`
# is safe even without a `dtolnay/rust-toolchain` step — the
# pre-installed Rust toolchain on ubuntu-latest lives in
# `~/.rustup` + `~/.cargo`, not `/opt/hostedtoolcache`, so
# `rustup target add` below still resolves.
# is the largest in any of the linux jobs.
#
# Runs BEFORE checkout: the action copies a `bc` binary into its
# working dir, which dirty's the checkout.
uses: endersonmenezes/free-disk-space@v3 # Use @main for latest, @v3 for stable
with:
remove_android: true
remove_dotnet: true
remove_haskell: true
remove_tool_cache: true
- uses: actions/checkout@v7

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔒 Security & Privacy | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check if CODEOWNER review is required for this PR's workflow file changes.
# Verify the repo rulesets and CODEOWNERS file for .github/workflows/release.yml.

# Check CODEOWNERS for workflow ownership
fd -t f CODEOWNERS .github/ 2>/dev/null | head -5
fd -t f CODEOWNERS . 2>/dev/null | head -5

# If found, grep for workflow-related ownership rules
fd -t f CODEOWNERS . -d 1 2>/dev/null -x cat {} \; 2>/dev/null | grep -i workflow

Repository: gominimal/minimal

Length of output: 174


🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== CODEOWNERS =="
cat -n .github/CODEOWNERS

echo
echo "== workflow snippets =="
sed -n '200,225p' .github/workflows/release.yml

echo
echo "== paths matched by CODEOWNERS rules for workflows =="
python3 - <<'PY'
from pathlib import Path

codeowners = Path('.github/CODEOWNERS').read_text().splitlines()
rules = []
for raw in codeowners:
    line = raw.strip()
    if not line or line.startswith('#'):
        continue
    parts = line.split()
    if len(parts) >= 2:
        rules.append((parts[0], parts[1:]))

for pat, owners in rules:
    if 'workflow' in pat.lower() or pat.startswith('.github/'):
        print(f"{pat} -> {' '.join(owners)}")
PY

Repository: gominimal/minimal

Length of output: 1768


🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Find any repo policy/rules docs that mention workflow changes or CODEOWNERS gating.
rg -n --hidden --glob '!.git' -e 'workflow' -e 'CODEOWNER' -e 'ruleset' -e 'frozen' README* .github . 2>/dev/null | head -200

Repository: gominimal/minimal

Length of output: 17993


Workflow edits need owner approval. .github/workflows/release.yml is part of the frozen CI layer and covered by @gominimal/minimalists, so this change should only merge with CODEOWNER review.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/release.yml around lines 209 - 221, Do not merge the
workflow change without approval from the CODEOWNER group
`@gominimal/minimalists`, as required for the frozen CI layer; obtain and preserve
the required owner review for the release workflow edits.

Sources: Coding guidelines, Learnings

@twitchyliquid64
twitchyliquid64 merged commit ddb60ee into main Jul 17, 2026
28 checks passed
@twitchyliquid64
twitchyliquid64 deleted the tom/session-inner branch July 17, 2026 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants