fix(minimald): hide unplumbed --stdlib-dir and -n args from help - #846
Merged
Conversation
`GlobalArgs` declared `--stdlib-dir` and `-n`/`--num-parallel-builds`, but neither is read anywhere in the daemon: the microVM path hardcodes both to `None` and the server `Config` consumes neither. `--stdlib-dir` was hidden only outside `MINIMAL_SCIENCE_MODE`, and `-n` was fully user-visible dead surface. Hide both unconditionally with `hide = true` so they no longer appear in help output. They are not plumbed even in science mode, so there is no reason to surface them there either. The flags still parse and are silently accepted, preserving backward compatibility for any callers already passing them. Closes: #825 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Changesminimald CLI
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related issues
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Comment |
twitchyliquid64
approved these changes
Jul 20, 2026
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
minimald'sGlobalArgsdeclares--stdlib-dirand-n/--num-parallel-builds, but neither is read anywhere in the daemon — the microVM path hardcodes both toNoneand the serverConfigconsumes neither.--stdlib-dirwas hidden only outsideMINIMAL_SCIENCE_MODE, while-nwas fully user-visible dead surface.This hides both unconditionally with
#[clap(hide = true)]so they no longer appear in help output. Since neither is plumbed even in science mode, there's no reason to surface them there. The flags still parse and are silently accepted, so any caller already passing them keeps working.Change
Testing
cargo build -p minimaldcargo clippy -p minimald --all-targets -- -D warningscargo fmt -p minimaldCloses #825
🤖 Generated with Claude Code
Summary by CodeRabbit
--stdlib-dircommand-line option is now consistently hidden from help output.