(via norrietaylor): Add validation for BULK_ACTIVATE_TIMEOUT_SECS in bulk-upload-e2e.sh - #888
Merged
macroscopeapp[bot] merged 1 commit intoJul 22, 2026
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Free Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
macroscopeapp
Bot
merged commit Jul 22, 2026
a943399
into
test/bulk-upload-canary-869
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds input validation for
BULK_ACTIVATE_TIMEOUT_SECSin the bulk upload end-to-end test script.Changes
DEADLINE_SECSassignment (line 86) to ensureBULK_ACTIVATE_TIMEOUT_SECSis a positive integerITERWhy
This ensures the script fails early with a clear error if
BULK_ACTIVATE_TIMEOUT_SECSis misconfigured, rather than encountering cryptic failures later in execution.Note
Macroscope: Fix It For Me
Activity
Currently: Auto-merged a943399
Previously
Note
Add input validation for
BULK_ACTIVATE_TIMEOUT_SECSinbulk-upload-e2e.shThe script now validates
BULK_ACTIVATE_TIMEOUT_SECSbefore proceeding: it rejects empty, non-integer, or sub-1 values by printing an error to stderr and exiting with status 2.Macroscope summarized fa871b8.