(via norrietaylor): fix(diag): check debugfs exit status in volume_fallback harvest - #890
Merged
macroscopeapp[bot] merged 1 commit intoJul 22, 2026
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Free Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
macroscopeapp
Bot
merged commit Jul 22, 2026
0bacb82
into
feat/diag-unit7-guest-fetch
2 checks passed
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue in the
volume_fallbackharvest function where debugfs failures were being silently recorded as successes.Problem
Previously, when the
debugfscommand completed (i.e., the process spawned and ran), the code only checked that the process execution succeeded—not whether debugfs itself reported an error via its exit status. This meant that partial or failed dumps would be recorded as successful harvests, hiding real issues from operators.Solution
Added a check for
out.status.success()in theOk(Ok(out))match arm before treating the harvest as successful. When debugfs exits with a nonzero status code, the function now:This ensures that failed debugfs operations are properly surfaced in diagnostics rather than silently passing.
Note
Macroscope: Fix It For Me
min bug#880.Activity
Currently: Auto-merged 0bacb82
Previously
Note
Fix
volume_fallbackto record a skip whendebugfsexits with a non-zero statusPreviously, guest.rs only recorded a skip when
debugfsran successfully but harvested zero files. A non-zero exit code was silently ignored.Now, the exit status is checked first: if
debugfsfails, a skip is recorded with the exit code and the first line of stderr. The zero-harvest check only runs on a successful exit.Macroscope summarized 880b580.