(via norrietaylor): Add error checking to mktemp calls for WORK variable in bulk-upload-e2e. - #903
Merged
macroscopeapp[bot] merged 1 commit intoJul 22, 2026
Conversation
macroscopeapp
Bot
merged commit Jul 22, 2026
8832709
into
test/bulk-upload-canary-869
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added error checking to both
mktempcalls for theWORKvariable inscripts/bulk-upload-e2e.shto ensure the script fails safely if temporary directory creation fails.Changes
mktempcall on line 118 (Darwin/macOS path)mktempcall on line 122 (Linux path)mktempfailsMotivation
Without this check, if
mktempfails andWORKis empty or invalid, the EXIT trap could potentially executerm -rfon an unintended path, risking destruction of unrelated developer sessions or files. The script now fails fast with a clear error message, preventing this dangerous scenario.Note
Macroscope: Fix It For Me
Activity
Currently: Auto-merged 8832709
Previously
Note
Add error handling to
mktempcalls forWORKvariable inbulk-upload-e2e.shOn both macOS and non-macOS branches, the
mktempcall that creates theWORKtemp directory now fails fast: ifmktempreturns a non-zero exit code, the script prints an error to stderr and exits with status 1 instead of continuing with an empty or invalid path.Macroscope summarized 917320e.