Skip to content

revert(minimald): revert the 8 MiB guest vsock receive window - #916

Merged
norrietaylor merged 2 commits into
mainfrom
revert/885-vsock-rx-window
Jul 22, 2026
Merged

revert(minimald): revert the 8 MiB guest vsock receive window#916
norrietaylor merged 2 commits into
mainfrom
revert/885-vsock-rx-window

Conversation

@norrietaylor

@norrietaylor norrietaylor commented Jul 22, 2026

Copy link
Copy Markdown
Member

Reverts commit 48236533 (#885), removing set_vsock_rx_window and the 8 MiB SO_VM_SOCKETS_BUFFER_MAX_SIZE/SO_VM_SOCKETS_BUFFER_SIZE bump on the vsock listener. Clean revert, single file (crates/minimald/src/main.rs), no other code references the removed symbols.

Note for reviewers: #885 measurably fixed bulk-upload ENOBUFS failures (6/6 → 0/6 on the 12.8 MB fixture, per its commit message), so the bulk-upload canary from #887 may regress once this lands unless the underlying libkrun fix is already in place.

Refs: #869

🤖 Generated with Claude Code

Note

Revert 8 MiB guest vsock receive window in minimald

Removes the VSOCK_RX_WINDOW_BYTES constant and the set_vsock_rx_window helper from main.rs, along with the call in async_main that raised SO_VM_SOCKETS_BUFFER_MAX_SIZE and SO_VM_SOCKETS_BUFFER_SIZE via setsockopt. The vsock listener now uses kernel-default receive window sizes. Behavioral Change: debug/warn logs about window sizing and ENOBUFS risks are no longer emitted, and accepted sockets will operate at the kernel default rather than 8 MiB.

Macroscope summarized 4b284cd.

Reverts commit 4823653 (PR #885).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 41 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6ffaace7-0dfc-4dd7-a3ac-1d938579fe81

📥 Commits

Reviewing files that changed from the base of the PR and between 356a08f and 4b284cd.

📒 Files selected for processing (1)
  • crates/minimald/src/main.rs

Comment @coderabbitai help to get the list of available commands.

@norrietaylor
norrietaylor enabled auto-merge (squash) July 22, 2026 18:44
@norrietaylor
norrietaylor merged commit b0f07a2 into main Jul 22, 2026
29 checks passed
@norrietaylor
norrietaylor deleted the revert/885-vsock-rx-window branch July 22, 2026 19:04
twitchyliquid64 pushed a commit that referenced this pull request Jul 22, 2026
Reverts commit b0f07a2 (PR #916), which reverted 4823653 (PR #885).

#885 was reverted before the libkrun fix had been tested in production.
That test has now run and the fix is not sufficient on its own: the
shipped 6d239bc build carries the fill loop and still fails, because
the loop exits on EAGAIN with a partly filled descriptor whenever the
writer is slower than libkrun's reader.

The window is the one measure with an unambiguous result behind it --
0 of 6 failures at 8 MiB against 6 of 6 on the same machine at the
256 KiB default. It raises the skb-depth ceiling from 455 queued
packets to 14,563, which is the bound every observed reset has hit.

This is headroom, not immunity: it does not change the ratio between
the two ceilings, it keeps a normal upload out of the fragmented tail
where the reset happens. It belongs alongside a libkrun fix rather
than instead of one.

Note `SO_VM_SOCKETS_BUFFER_MAX_SIZE` must be raised before
`SO_VM_SOCKETS_BUFFER_SIZE`: vsock_update_buffer_size() clamps the
latter to the former and both default to 256 KiB, so the obvious
ordering silently changes nothing.

Refs: #869
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants