revert(minimald): revert the 8 MiB guest vsock receive window - #916
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 41 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Comment |
Reverts commit b0f07a2 (PR #916), which reverted 4823653 (PR #885). #885 was reverted before the libkrun fix had been tested in production. That test has now run and the fix is not sufficient on its own: the shipped 6d239bc build carries the fill loop and still fails, because the loop exits on EAGAIN with a partly filled descriptor whenever the writer is slower than libkrun's reader. The window is the one measure with an unambiguous result behind it -- 0 of 6 failures at 8 MiB against 6 of 6 on the same machine at the 256 KiB default. It raises the skb-depth ceiling from 455 queued packets to 14,563, which is the bound every observed reset has hit. This is headroom, not immunity: it does not change the ratio between the two ceilings, it keeps a normal upload out of the fragmented tail where the reset happens. It belongs alongside a libkrun fix rather than instead of one. Note `SO_VM_SOCKETS_BUFFER_MAX_SIZE` must be raised before `SO_VM_SOCKETS_BUFFER_SIZE`: vsock_update_buffer_size() clamps the latter to the former and both default to 256 KiB, so the obvious ordering silently changes nothing. Refs: #869
Reverts commit
48236533(#885), removingset_vsock_rx_windowand the 8 MiBSO_VM_SOCKETS_BUFFER_MAX_SIZE/SO_VM_SOCKETS_BUFFER_SIZEbump on the vsock listener. Clean revert, single file (crates/minimald/src/main.rs), no other code references the removed symbols.Note for reviewers: #885 measurably fixed bulk-upload ENOBUFS failures (6/6 → 0/6 on the 12.8 MB fixture, per its commit message), so the bulk-upload canary from #887 may regress once this lands unless the underlying libkrun fix is already in place.
Refs: #869
🤖 Generated with Claude Code
Note
Revert 8 MiB guest vsock receive window in
minimaldRemoves the
VSOCK_RX_WINDOW_BYTESconstant and theset_vsock_rx_windowhelper from main.rs, along with the call inasync_mainthat raisedSO_VM_SOCKETS_BUFFER_MAX_SIZEandSO_VM_SOCKETS_BUFFER_SIZEviasetsockopt. The vsock listener now uses kernel-default receive window sizes. Behavioral Change: debug/warn logs about window sizing and ENOBUFS risks are no longer emitted, and accepted sockets will operate at the kernel default rather than 8 MiB.Macroscope summarized 4b284cd.