(via norrietaylor): fix(diag): continue directory walk when sessions/index.json is absent - #913
Merged
macroscopeapp[bot] merged 1 commit intoJul 22, 2026
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Free Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
macroscopeapp
Bot
merged commit Jul 22, 2026
66e57a4
into
feat/diag-unit6-daemon-bundle
2 checks passed
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the diagnostic directory walk to continue when
sessions/index.jsonis absent, instead of returning early.Changes
Updated the
sessionsfunction to callw.skip("sessions/index.json", "not present")instead of returning early when the index file is missing (Ok(None)case). This allows the directory enumeration logic to proceed and collect orphan session records even when the index file doesn't exist.Motivation
Previously, if
sessions/index.jsonwas not present, the function would return immediately, preventing detection of orphan session records in the directory. Now the diagnostic walk continues, providing more complete diagnostic information regardless of whether the index file exists.Note
Macroscope: Fix It For Me
Activity
Currently: Auto-merged 66e57a4
Previously
Note
Fix directory walk in
sessionsto continue whensessions/index.jsonis absentPreviously, a missing
sessions/index.jsoncaused thesessionsfunction in diag.rs to return early, skipping enumeration of the sessions directory entirely. Now it records a skip note for the missing index and continues walking the directory so session records are still considered.Macroscope summarized 5cd2b31.