Skip to content

revert(minimald): revert the 8 MiB guest vsock receive window - #924

Merged
norrietaylor merged 1 commit into
mainfrom
tom/session-sop
Jul 22, 2026
Merged

revert(minimald): revert the 8 MiB guest vsock receive window#924
norrietaylor merged 1 commit into
mainfrom
tom/session-sop

Conversation

@twitchyliquid64

@twitchyliquid64 twitchyliquid64 commented Jul 22, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

This reverts commit ff79c8c.

Summary

Testing

Checklist

  • Docs updated if behavior changed
  • BREAKING CHANGE: footer present if this is a breaking change

Note

Revert 8 MiB guest vsock receive window in minimald

Removes the VSOCK_RX_WINDOW_BYTES constant and the set_vsock_rx_window helper from main.rs, along with the call in async_main that raised SO_VM_SOCKETS_BUFFER_MAX_SIZE and SO_VM_SOCKETS_BUFFER_SIZE via setsockopt. The vsock listener now uses kernel-default receive window sizes. Behavioral Change: debug/warn logs about window sizing and ENOBUFS risks are no longer emitted, and accepted sockets will operate at the kernel default rather than 8 MiB.

Macroscope summarized d3b11e9.

Summary by CodeRabbit

  • Bug Fixes
    • Improved vsock listener startup reliability by removing the custom receive-window adjustment.
    • The service now proceeds directly from listener setup to readiness and server startup.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The Linux vsock listener startup no longer adjusts the AF_VSOCK receive window. The related constant, startup call and logging, and socket-option helper were removed.

Changes

Vsock startup behavior

Layer / File(s) Summary
Remove receive-window configuration
crates/minimald/src/main.rs		 Removes the requested window constant, startup tuning and logging, and the helper that configured and read back kernel vsock buffer sizes.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: norrietaylor

Poem

I’m a rabbit by the vsock stream,
No buffer tuning haunts the dream.
The listener binds, the path runs clear,
Startup hops without that gear.
Carrot cheers for simpler code!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description mostly contains placeholders and lacks real Summary, Testing evidence, and checklist completion. Fill in the Summary with the change and why, add testing commands/results, and complete the checklist items that apply.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title is clear, specific, and accurately summarizes the revert of the 8 MiB guest vsock receive window.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@norrietaylor
norrietaylor enabled auto-merge (squash) July 22, 2026 23:31
@norrietaylor
norrietaylor merged commit 1efde29 into main Jul 22, 2026
29 checks passed
@norrietaylor
norrietaylor deleted the tom/session-sop branch July 22, 2026 23:45
@norrietaylor norrietaylor mentioned this pull request Jul 23, 2026
Closed
@coderabbitai coderabbitai Bot mentioned this pull request Jul 23, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@norrietaylor norrietaylor norrietaylor approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@twitchyliquid64 @norrietaylor