fix(ci): boot the macOS VM lane on guest-pin bumps - #935
Conversation
The macOS lane's dorny/paths-filter `macos` block omitted `.minimal/minimal.toml`, so a PR that only bumped the guest kernel / rootfs / libkrun pin produced `changes.outputs.macos == 'false'` and skipped the HVF VM-boot jobs — the bump merged without a macOS VM boot. Add the guest pin to the filter, matching the KVM lane, which already lists it. Filter-only change; the ci-macos-success aggregator and every job gate are untouched, so path-skipped PRs still report green. Codeowner-approved edit to the otherwise-frozen .github/workflows tree. Closes #897 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 12 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Comment |
Problem
The macOS lane gates its expensive HVF VM-boot jobs (
artifacts,unit,e2e) behind an in-workflowdorny/paths-filtermacosblock. That block omitted.minimal/minimal.toml, so a PR that only bumped the guest kernel / rootfs / libkrun pin producedchanges.outputs.macos == 'false'and skipped every macOS VM job — the bump merged without a macOS VM boot. The Linux/KVM lane already lists.minimal/minimal.tomlin its filter and boots on such bumps; macOS was the arch-specific (aarch64/HVF) gap.Fix
Add
.minimal/minimal.tomlto themacosfilter list, matching the KVM lane. A pin-only PR now matches the filter, so the HVF VM boot runs as a pre-merge gate.ci-macos-successaggregator (if: always()) and every job gate are untouched, so PRs that do not match the filter still path-skip cleanly and report green.This is a codeowner-approved edit to the otherwise-frozen
.github/workflows/tree.Closes #897
Note
Trigger macOS CI lane on guest pin (
minimal.toml) changesAdds
.minimal/minimal.tomlto themacospath filter in ci-macos.yml so that bumping the guest pin triggers the macOS HVF boot job, matching the existing KVM lane behavior.Macroscope summarized 5c8a773.