docs(readme): declare session tools via [session] packages, not min add --session - #946
Closed
norrietaylor wants to merge 2 commits into
Closed
docs(readme): declare session tools via [session] packages, not min add --session#946norrietaylor wants to merge 2 commits into
norrietaylor wants to merge 2 commits into
Conversation
…dd --session The host `min add` command accepts only `--runtime`, `--build`, or `--task <NAME>`; it has no `--session` flag (that flag exists only on the in-sandbox `min add` helper). The Getting Started examples ran `min add --session ...` on the host before `min activate`, which fails. Replace both host invocations with the correct flow: after `min init`, declare session tools by editing the scaffolded `[session]` packages list in `minimal.toml`, mirroring docs/guide/setup.md. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
📝 WalkthroughWalkthroughThe README Getting Started walkthrough now instructs readers to edit the generated ChangesREADME session setup
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
Comment |
norrietaylor
marked this pull request as ready for review
July 23, 2026 22:54
min init scaffolds [session] packages = ["base", "vim"] and only appends "git" when .git already exists (crates/op/src/project/init.rs); in these examples min init runs before git init, so state the scaffolded starting list explicitly instead of implying the fuller list is generated. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Member
|
We can also make this have parity with the in-sandbox version |
This was referenced Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The host
min addcommand accepts only--runtime,--build, or--task <NAME>(seeAddKindincrates/minimal/src/lib.rs). It has no--sessionflag: that flag exists only on the separate in-sandboxmin addhelper. The Getting Started quickstarts ranmin add --session ...on the host, beforemin activate, which fails.This replaces both host-level invocations with the correct flow: after
min init, declare the desired session tools by editing the scaffolded[session]packageslist inminimal.toml, mirroring the wording indocs/guide/setup.md.The valid in-sandbox
min addcomment (agents adding tools dynamically from inside a session) is left untouched.Note
Update README to declare session tools via the
[session]packages listReplaces the
min add --sessioncommand pattern in README.md with instructions to edit the scaffolded[session]table inminimal.tomldirectly. Adds example package lists in comments to show both a minimal and a larger set of session tools.Macroscope summarized bf1805f.
Summary by CodeRabbit
minimal.tomlafter initialization.