fix(minimald): fix resizing terminal - #969
Merged
Merged
Conversation
twitchyliquid64
enabled auto-merge (squash)
July 25, 2026 06:25
📝 WalkthroughWalkthroughChangesSSH input and resize routing
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related issues
Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/minimald/src/session_host.rs`:
- Around line 1802-1804: Add a regression test covering the window-change path
from ChannelMsg::WindowChange through Binding to Host::set_size, rather than
only StdinMsg::Bytes. Assert that the PTY and parser dimensions update after the
request, including the oversized-dimension behavior described by the
implementation.
- Around line 1553-1559: Clamp col_width, row_height, pix_width, and pix_height
to the u16 range in the StdinMsg::WindowChange handler before casting them and
constructing WinSize. Match the existing bounds used by
WinSize::from(&RequestedPty), preserving valid values while preventing oversized
SSH dimensions from wrapping.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 708268a9-8722-4fce-976b-12522771ee80
📒 Files selected for processing (1)
crates/minimald/src/session_host.rs
norrietaylor
approved these changes
Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #965
Dragged claude code around a bunch, seemed to update the screen properly.
Note
Fix terminal resizing in
minimaldby handling SSHWindowChangeeventsIntroduces a
StdinMsgenum in session_host.rs to replace the previousEither<Bytes, RequestedPty>channel type. The new enum adds aWindowChangevariant that carries terminal dimensions, allowing the SSH binding to forward resize events to the host's main loop, which callsset_sizewith the updated dimensions.Macroscope summarized 7e5e080.
Summary by CodeRabbit
New Features
Bug Fixes