Repository navigation
SECURITY: zellij links the system SQLite, not a bundled pre-3.54.0 copy (CVE-2026-119375) - #1463
Conversation
…-119375) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Without rusqlite's bundled feature, libsqlite3-sys no longer pulls its optional cc build-dependency, and the --locked build refused to rewrite the lock (build-bot FTBFS on amd64 and arm64). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
agent-137
left a comment
There was a problem hiding this comment.
Approving at c482a89c on Karl's behalf. zellij now builds against the system SQLite (3.54.1) instead of rusqlite's bundled pre-3.54.0 copy. The Cargo.lock edit drops only cc from libsqlite3-sys's dependency list, which is the change --locked refused on the first head. Both edits fail the build if they stop matching, and the existing readelf check requires a NEEDED libsqlite3.so. The minimal build is green on both arches.
SECURITY: CVE-2026-119375 (RUSTSEC-2026-0459, GHSA-72w2-rjgg-q729). SQLite before 3.54.0 can return uninitialized page-cache memory when it opens a database together with a
-walfile whose page size differs. A crafted pair of files makes ordinary queries return stale bytes from the process. The attack is local, and the victim has to open the files.zellij-utils enables rusqlite 0.30 with its
bundledfeature (switched on byweb_server_capability, which our build enables). That compiles libsqlite3-sys 0.27.0's own pre-3.54.0 SQLite into the zellij we ship. Per the advisory, only the bundled build is affected. Oursqlitepackage is 3.54.1.This PR:
bundledfrom zellij-utils' rusqlite line before compiling, so libsqlite3-sys links the system libsqlite3. It fails closed ifbundledis still there or the line has changed shape, and after the compile it requiresNEEDED libsqlite3.so(the same pattern as the existing libcurl check). It also deletes the one Cargo.lock line the feature change implies: withoutbundled, libsqlite3-sys no longer pulls its optionalccbuild-dependency, so"cc",leaves libsqlite3-sys's dependency list.ccitself stays, since 13 other crates use it. Without that edit, the--lockedbuild refused to rewrite the lock (the first build-bot run failed this way on both arches). The edit is guarded both ways: the build fails ifccis still listed or if libsqlite3-sys is no longer 0.27.0.sqliteas a build dep andsubsetOf sqlite ["libs"]as a runtime dep.Tested off-host against v0.45.1's real
zellij-utils/Cargo.toml: the substitution matches exactly once, rusqlite stays optional behindweb_server_capability, and both guards pass. As a negative control, the unpatched file fails thebundledguard. CI's build is the first compile.Rebuilds: 1 (zellij;
mip dump --packages, amd64).Why now: pkgmgr refused zellij 0.46.0 on 2026-11-12 (
lock_patch_refused) because the libsqlite3-sys floor (0.39.0) needs rusqlite 0.41, an API break. This fixes the CVE on the version we ship, independently of the bump. The pkgmgr side, so that it stops demanding that floor for zellij and stops flagging test-only crates such assccviaserial_test, is separate work.🤖 Generated with Claude Code
Summary by CodeRabbit