Repository navigation
openssl, openssl-3.5: carry OpenSSL's November 2026 security fixes (8 Low CVEs) as patches - #1571
Draft
bryan-minimal wants to merge 1 commit into
Draft
bryan-minimal wants to merge 1 commit into
bryan-minimal wants to merge 1 commit into
Conversation
… patches OpenSSL published eight Low-severity advisories on 2026-11-10 and 2026-11-17, fixed in 3.5.10 / 4.0.4 / 4.1.1, none of which is released yet. Carry upstream's own fix commits, from the openssl-4.1 branch for packages/openssl (4.1.0) and the openssl-3.5 branch for packages/openssl-3.5 (3.5.9): CVE-2026-88823 AES-GCM-SIV AAD forgery after zero-length AAD update CVE-2026-107496 CMS_encrypt() infinite loop with EC group order 1 CVE-2026-88822 QUIC uninitialised stack bytes in peer detection CVE-2026-95692 AES-GCM-SIV OOB read / IV length handling CVE-2026-95691 QUIC CRYPTO frame retransmit DoS / 1-byte disclosure CVE-2026-107493 PEM_X509_INFO_read_bio_ex() use-after-free CVE-2026-35190 TLS 1.3 key-share OOB read with the Suite B flag CVE-2026-124709 QUIC server unbounded memory for rejected streams Patches are applied in branch order with -F0, every touched file sha256-checked before and after (llama.cpp's style), and all apply with no fuzz or offset to the mirrored release tarballs. One change from upstream: the 4.1 CVE-2026-124709 patch drops its test/quicapitest.c hunks (one does not apply to 4.1.0); its code hunk is verbatim and identical to the code-only 3.5 backport. Both packages gain a `patch` build dep. Drop the blocks when version >= 4.1.1 / 3.5.10. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenSSL published eight advisories on 2026-11-10 and 2026-11-17 (vulnerabilities list). All are rated Low. The fixes are in 3.5.10, 4.0.4 and 4.1.1, and none of those versions has been released yet. This PR carries upstream's own fix commits as patches on both of our OpenSSL lines:
packages/openssl4.1.0 takes the commits from theopenssl-4.1branch.packages/openssl-3.53.5.9 takes the commits from theopenssl-3.5branch.CMS_encrypt()with an EC group order of 1PEM_X509_INFO_read_bio_ex()Every commit is the one the advisory links for that branch. I also checked that each is an ancestor of the branch head.
How they're applied
stbstyle.build.shapplies them in the order they landed on the branch, usingpatch -Np1 -F0. Every file a patch touches is sha256-checked before and after it is applied. A different tarball or a partial apply therefore fails the build.git format-patchoutput from upstream, with one exception. In the 4.1 copy of CVE-2026-124709, I removed thetest/quicapitest.chunks because one of them does not apply to the 4.1.0 test file. The code hunk (ssl/quic/quic_stream_map.c) is verbatim and byte-identical to the 3.5 backport, which upstream itself shipped without tests. A note at the top of the patch file records the change.build.ncl, extracted into fresh dirs:build.shpatch block, and only that block, against a fresh tree for each package, and both pass.build.nclevaluates on amd64 and arm64 with the local Nickel shim.test/ectest.c,test/x509_check_cert_pkey_test.c) are compiled bymake, so the build-bot is the first real compile check.patchbuild dep.patchreachesopensslonly throughglibc→python, which is the same routetoolchain(already a build dep) takes, so the dependency graph keeps its existing shape. The planner is the real judge of this, though.Not carried
None. All eight CVEs are carried on both packages. (We ship no 4.0.x, 3.0.x or 1.1.1 OpenSSL.)
⚠ Rebuild impact
Merging this rebuilds essentially the whole world:
opensslis a build dep ofpython, which is a build dep ofglibc. By import closure, 569 of 570 packages sit downstream.openssl-3.5feedsrustc-1.98.1/rustc-1.99.1, the Rust ladder, plusactions-runnerandfoundationdb.It needs a full queue window: the build-bot is serial and the queue has a 6h timeout.
When 4.1.1 / 3.5.10 ship
Drop the patch block in
build.shand thecve-2026-*.patchfiles on the version bump. The before-hashes make a bump that keeps the block fail closed, so a missed drop cannot go unnoticed.🤖 Generated with Claude Code