Skip to content

Remove orphaned rustc-1.98.1 and llvm-21 (nothing imports them since rust 1.100) - #1578

Open
bryan-minimal wants to merge 3 commits into
mainfrom
drop-rustc-1.98.1-llvm-21
Open

bryan-minimal wants to merge 3 commits into
mainfrom
drop-rustc-1.98.1-llvm-21

Conversation

@bryan-minimal

Copy link
Copy Markdown
Member

Removes two packages nothing imports any more. Each is in its own commit.

  1. rustc-1.98.1. rust 1.100 (rust 1.99.1 -> 1.100.0 on a gen-16 rustc-1.99.1 stage0 (LLVM 23); drops bun's 1.99 shims #1493) builds on rustc-1.99.1, so this ladder rung has no importer. It was also one of openssl-3.5's libssl.so.3 users; openssl-3.5's header now lists the three that remain:
    • rustc-1.99.1 (bootstrap's sealed cargo);
    • actions-runner (.NET 8, being moved to .NET 10);
    • foundationdb 7.3 (no OpenSSL 4 support, not even in 8.0.1).
  2. llvm-21. Its last importer was rustc-1.98.1. It was kept for the Rust rungs 1.91.1–1.98.1, and emscripten and bun have since moved to llvm-23. It's a full LLVM build in every world rebuild. llvm-bootstrap is unaffected, because it builds its own LLVM 21 source. Drop this commit to keep llvm-21 installable for users.
  3. .github/scripts/test_ci_scope.py: the versioned.ncl importer count goes from 3 to 2, since only llvm-22 and llvm-23 import it now. All 15 tests pass locally.

The comment edits in llvm/build.ncl and openssl-3.5/build.ncl change comments only.

Follow-up in pkgmgr-rs after merge: remove the now-dead llvm-21 series pin and signing policy, and the rustc-1.98.1 frozen-package entry.

🤖 Generated with Claude Code

bryan-minimal and others added 3 commits November 18, 2026 14:53
rust 1.100 (#1493) builds on rustc-1.99.1, so the 1.98.1 ladder rung has no
importer. Removing it also drops one of openssl-3.5's libssl.so.3 users;
openssl-3.5's header now lists the three that remain (rustc-1.99.1,
actions-runner, foundationdb).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
llvm-21 was kept for the Rust ladder rungs rustc-1.91.1..1.98.1 (emscripten
and bun have since moved to llvm-23). With rustc-1.98.1 gone nothing
imports it, and it is a full LLVM build in every world rebuild.
llvm-bootstrap is unaffected: it builds its own LLVM 21 source.
Drop this commit to keep llvm-21 installable for users.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bryan-minimal
bryan-minimal requested a review from a team as a code owner November 18, 2026 22:54
@coderabbitai

coderabbitai Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

  • Run on-demand review

This review includes 5 billable files and costs up to $1.25.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 51 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 64 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 9cebbef and d27600f.

Files selected for processing: 5

  • .github/scripts/test_ci_scope.py
  • packages/llvm-21/build.ncl
  • packages/llvm/build.ncl
  • packages/openssl-3.5/build.ncl
  • packages/rustc-1.98.1/build.ncl
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant