git: 2.55.0 + Rust toolchain (libgitcore.a) - #377
Conversation
git 2.55.0's Makefile builds a Rust component (target/release/libgitcore.a via cargo) as part of the default build, which 2.54.0 didn't. Add `rust` to build_deps so cargo is on PATH, and set RUSTFLAGS with --remap-path-prefix so the Rust static lib is reproducible (mirrors the existing C -ffile-prefix-map). Build-proven in a clean-main worktree: - `minimal package --rebuild git` → EXIT 0 (was FTBFS: `cargo: command not found`) - rustc-1.95.0 marker embedded in usr/bin/git → libgitcore compiled + linked - two --rebuild passes byte-identical (sha256 509eb189…) → reproducible - no host paths leaked into the binary → remap works Closes #376.
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 48 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
What
Bumps
git2.54.0 → 2.55.0 and adds the Rust toolchain as a build dep.git 2.55.0's Makefile now compiles a Rust component (
target/release/libgitcore.aviacargo) as part of the default build — 2.54.0 didn't. Without a cargo on PATH the build FTBFS withcargo: command not found(this is why git was dropped from the #375 auto-bundle → tracked as #376).Change
build.ncl: addrusttobuild_deps(same toolchain ~dozens of pure-Rust packages already use).build.sh:export RUSTFLAGS="-C linker=gcc --remap-path-prefix=$(pwd)=/builddir --remap-path-prefix=$HOME/.cargo=/cargo"so the Rust static lib is reproducible, mirroring the existing C-ffile-prefix-map.Build-proven (clean-main worktree,
minimal package --rebuild git)cargo: command not found/make: *** [libgitcore.a] Error 127.strings usr/bin/gitcontainsrustc version 1.95.0 (…) (built from a source tarball); libgitcore compiled with our rust toolchain.--rebuildpasses produced a byte-identicalgit(sha256509eb189…)./Users/bryanin the binary; the RUSTFLAGS remap works.Note for reviewers
This makes git build-depend on the whole Rust toolchain — a real supply-chain expansion, which is why it's a deliberate standalone PR rather than an auto-bundle bump. That's the intended trade (git upstream is migrating to Rust).
Closes #376.