Skip to content

feat(ci): use minimal check GHA workflow - #400

Merged
twitchyliquid64 merged 1 commit into
mainfrom
tom/stacks
Jul 13, 2026
Merged

feat(ci): use minimal check GHA workflow#400
twitchyliquid64 merged 1 commit into
mainfrom
tom/stacks

Conversation

@twitchyliquid64

@twitchyliquid64 twitchyliquid64 commented Jul 13, 2026

Copy link
Copy Markdown
Member

Just uses the new GHA we made rather than shelling out ourselves.

Summary by CodeRabbit

  • Chores
    • Updated the continuous integration checks to use the latest minimal-check workflow.
    • Configured validation to run against the unstable channel.

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The minimal-check CI job replaces its local setup and command sequence with gominimal/check@v1, configured to use the unstable channel.

Changes

Minimal check CI

Layer / File(s) Summary
Replace minimal-check workflow steps
.github/workflows/ci.yml
The minimal-check job now runs gominimal/check@v1 with channel: unstable.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: bryan-minimal, jakeyrg, jtnkminimal

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the CI change to use the minimal check GitHub Actions workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch tom/stacks

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.github/workflows/ci.yml (1)

23-25: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick win

Pin the new third-party action to a full commit SHA.

@v1 is a movable tag, so the action implementation can change without a workflow diff. Pin the verified release commit while retaining v1 in a comment for maintainability. GitHub recommends full-length SHA pinning for third-party actions. (docs.github.com)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/ci.yml around lines 23 - 25, Update the gominimal/check
action reference to use the verified full commit SHA instead of the movable `@v1`
tag, and retain `@v1` in an adjacent comment for maintainability. Keep the
existing channel: unstable configuration unchanged.

Source: MCP tools

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In @.github/workflows/ci.yml:
- Around line 23-25: Update the gominimal/check action reference to use the
verified full commit SHA instead of the movable `@v1` tag, and retain `@v1` in an
adjacent comment for maintainability. Keep the existing channel: unstable
configuration unchanged.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 48a88fe4-03c0-429d-bff6-a03540b14aae

📥 Commits

Reviewing files that changed from the base of the PR and between cd4b09d and cb7b233.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

@bryan-minimal bryan-minimal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@twitchyliquid64
twitchyliquid64 added this pull request to the merge queue Jul 13, 2026
Merged via the queue into main with commit 7cb529b Jul 13, 2026
6 checks passed
@twitchyliquid64
twitchyliquid64 deleted the tom/stacks branch July 13, 2026 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants