Update stacked: 7 packages (#481 minus c-ares) - #484
Merged
Conversation
#481 bundled 8 packages and failed `minimal build` on both arches. The seven here are innocent — they were blocked by one member. c-ares 1.34.7 -> 1.34.8 breaks node's cares_wrap.cc: make[1]: *** [libnode.target.mk:420: .../libnode/src/cares_wrap.o] Error 1 ../src/cares_wrap.h:337: note: candidates are: Callback(void*, int, int, const hostent*) Callback(void*, ares_status_t, size_t, const ares_dns_record_t*) Overload resolution against the c-ares callback signature fails, and ares_set_servers / ares_get_servers_ports are now deprecated in favour of the _csv forms. The build order confirms the causal chain: c-ares finished at 9:41:15 and node started at 9:41:16 — node only rebuilt because c-ares changed. c-ares is left at 1.34.7 (matching main, verified by diff) so node and node-lts do not rebuild. It needs a separate PR that either patches cares_wrap or pairs the bump with a node version that compiles against the new API. Worth noting this was a PATCH release. Nothing in 1.34.7 -> 1.34.8 suggests an API break, which is exactly why bundling is load-bearing here: the cascade is only visible at build time. Same versions and checksums as #481, taken from that branch unmodified. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughSeven package build recipes bump upstream versions and update the corresponding source archive SHA-256 checksums. Build dependencies, commands, outputs, runtime dependencies, and other recipe structure remain unchanged. ChangesPackage source refreshes
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
twitchyliquid64
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks the seven packages in #481 that were held up by one member.
What happened to #481
minimal buildfailed on both arches in 53s. The check run carries no output (details_url: https://minimal.dev, empty title/summary — infra#316), so this came from the builder's own log, runa94de19c:c-ares 1.34.7 → 1.34.8breaks node'scares_wrap.cc. Overload resolution against the c-ares callback signature fails, andares_set_servers/ares_get_servers_portsare now deprecated in favour of the_csvforms.The build order confirms the causal chain rather than merely correlating with it:
c-aresnodenode only rebuilt because c-ares changed. #481's own build-risk table predicted the dependents (
node,node-lts); the API break is what it couldn't predict.This PR
The same 7 packages, at the same versions and checksums, taken from #481's branch unmodified:
c-aresstays at 1.34.7 — verified by diff againstmain— so neithernodenornode-ltsrebuilds. The diff is version +sha256only; no other file is touched.Still needs doing
c-ares 1.34.8 needs its own PR, pairing the bump with either a
cares_wrappatch or a node version that compiles against the new API. It should not be re-bundled until that's resolved, or it will block whatever it's bundled with again.Worth flagging that this was a patch release. Nothing about 1.34.7 → 1.34.8 signals an API break — which is the argument for the bundle build gate: the cascade is only visible at build time, never from the version number.
#481 can be closed in favour of this.
Note
#481 also dropped
atuinbefore building —new tarball size differs more than 2x from the previous artifact, i.e. the resolver likely picked a GitHub auto-archive instead of a release asset. That's a third, separate follow-up.🤖 Generated with Claude Code
Summary by CodeRabbit