Skip to content

Update node + c-ares - #485

Merged
twitchyliquid64 merged 2 commits into
mainfrom
tom/node-and-c-ares-fix
Jul 21, 2026
Merged

Update node + c-ares#485
twitchyliquid64 merged 2 commits into
mainfrom
tom/node-and-c-ares-fix

Conversation

@twitchyliquid64

@twitchyliquid64 twitchyliquid64 commented Jul 21, 2026

Copy link
Copy Markdown
Member

Bump c-ares, remove the patch that was necessary for 1.34.7 which was apparently an accidental breakage

Summary by CodeRabbit

  • Chores
    • Updated the bundled networking library to a newer release, bringing the latest maintenance updates.
    • Simplified Node.js build preparation by removing an obsolete compatibility adjustment.
    • Preserved existing build outputs, configuration, and validation behavior.

gominimal-pkgmgr-mgr Bot and others added 2 commits July 20, 2026 22:13
c-ares 1.34.8 (upstream PR #1244) reverts the const-ified callback
parameters introduced in 1.34.7, which upstream deemed an unintended API
break: existing applications with the historical non-const callback
signatures no longer compiled, particularly in C++ where function
pointer types must match exactly. ares_host_callback is back to taking
`struct hostent *`, and upstream opted to document the read-only nature
of the parameter instead.

That makes the sed patch added in c3f3fdf produce exactly the mismatch it
was written to fix — node fails to build against the new shared c-ares
with:

  src/cares_wrap.cc:1740:21: error: no matches converting function
  'Callback' to type 'ares_host_callback'

Drop the patch (and its self-verifying grep guard) from both build.sh
files; the unpatched node source matches the reverted signature.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c0bfe531-edde-41c8-bd28-c0cd584c74a8

📥 Commits

Reviewing files that changed from the base of the PR and between e54fd13 and 2efa78a.

📒 Files selected for processing (3)
  • packages/c-ares/build.ncl
  • packages/node-lts/build.sh
  • packages/node/build.sh
💤 Files with no reviewable changes (2)
  • packages/node/build.sh
  • packages/node-lts/build.sh

📝 Walkthrough

Walkthrough

Changes

c-ares and Node build updates

Layer / File(s) Summary
Update c-ares source release
packages/c-ares/build.ncl
The package source version changes from 1.34.7 to 1.34.8, with the matching archive checksum updated.
Remove Node c-ares patches
packages/node-lts/build.sh, packages/node/build.sh
Both Node build scripts remove the header-signature patch and its verification step before architecture selection.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: bryan-minimal

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and related to the main changes, covering the Node and c-ares update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch tom/node-and-c-ares-fix

Comment @coderabbitai help to get the list of available commands.

@bryan-minimal bryan-minimal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@twitchyliquid64
twitchyliquid64 added this pull request to the merge queue Jul 21, 2026
Merged via the queue into main with commit 5d23b03 Jul 21, 2026
10 checks passed
@twitchyliquid64
twitchyliquid64 deleted the tom/node-and-c-ares-fix branch July 21, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants