Skip to content

Revert #477: restore minimum_version 0.0.15, drop redistributable attr (unblock pinned-minimal consumers) - #536

Merged
bryan-minimal merged 1 commit into
mainfrom
revert/477-redistributable
Jul 28, 2026
Merged

Revert #477: restore minimum_version 0.0.15, drop redistributable attr (unblock pinned-minimal consumers)#536
bryan-minimal merged 1 commit into
mainfrom
revert/477-redistributable

Conversation

@bryan-minimal

Copy link
Copy Markdown
Member

Reverts #477. Restores minimum_version = "0.0.15" and removes the redistributable = false attr from android-sdk, claude-code, edgedelta.

Why

#477's minimum_version bump to 0.0.18 (required so old clients get a legible error instead of a raw decode failure on the new redistributable attr) hard-gates every consumer whose installed minimal ships stdlib < 0.0.18 — including conservative/pinned-minimal CI that pulls latest pkgs only for security fixes and never touches the three proprietary packages. Because the graph is loaded whole-catalog on every build and attr validation is closed, the new attr breaks those consumers regardless of their closure.

Reverting unblocks them immediately. 0.0.18 is the fix going forward, but it can't retroactively help clients already on an older pin.

⚠️ Compliance coupling — read before merging

The build-servers exclusion of these three packages (inbox#290 / #284) is driven by this attr. With the attr removed, is_redistributable defaults to true and the upload/seal filters stop excluding them, so the next canonical build re-uploads the proprietary artifacts to the public cache, undoing the 2026-07-28 purge.

Sequencing: this must be paired with a build-servers change that keeps the three packages out of the public cache independent of the pkgs attr (a name-based denylist), landed/deployed before or immediately after this merges — otherwise there is a re-exposure window on the next pkgs build. Do not merge this in isolation and leave it.

Kept open (not auto-merged) so the compliance follow-up can be sequenced deliberately.

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 31 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8595685a-06be-4fee-8f99-7e3b7f557e44

📥 Commits

Reviewing files that changed from the base of the PR and between d3cc912 and c6968ac.

📒 Files selected for processing (4)
  • minimal.toml
  • packages/android-sdk/build.ncl
  • packages/claude-code/build.ncl
  • packages/edgedelta/build.ncl
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert/477-redistributable

Comment @coderabbitai help to get the list of available commands.

@bryan-minimal
bryan-minimal enabled auto-merge July 28, 2026 20:58
@bryan-minimal
bryan-minimal added this pull request to the merge queue Jul 28, 2026
Merged via the queue into main with commit edab880 Jul 28, 2026
10 checks passed
@bryan-minimal
bryan-minimal deleted the revert/477-redistributable branch July 28, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants