Skip to content

fix(virtio-linux): add CONFIG_PROC_CHILDREN and fix broken kconfigs - #567

Merged
twitchyliquid64 merged 1 commit into
mainfrom
tom/kernel
Aug 5, 2026
Merged

fix(virtio-linux): add CONFIG_PROC_CHILDREN and fix broken kconfigs#567
twitchyliquid64 merged 1 commit into
mainfrom
tom/kernel

Conversation

@twitchyliquid64

@twitchyliquid64 twitchyliquid64 commented Aug 5, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member
  • Enable CONFIG_PROC_CHILDREN which is needed by minimald
  • Fix a ton of issues with the existing kconfigs
    • Lockdown patchset makes no sense on virtualized hardware, also it makes the kernel non-reproducible
    • A bunch of configs were NOOPs due to missing requirements and were dropped by olddefconfig. Fixed the ones that make sense, dropped the others

Summary by CodeRabbit

  • Improvements
    • Expanded built-in kernel support for Virtio, containers, networking, filesystems, BPF, cgroups, security, virtualization, and system introspection.
    • Improved compatibility across supported architectures with updated feature dependencies and corrected configuration options.
    • Enhanced reliability by validating required and prohibited kernel features during configuration.
    • Updated security support with Landlock, Yama, and BPF while disabling unsupported graphics and module-signing features.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d89bcf6f-5ab1-469e-b457-a4eeac70c969

📥 Commits

Reviewing files that changed from the base of the PR and between 88a1113 and d26936c.

📒 Files selected for processing (1)
  • packages/virtio-linux/build.sh
📝 Walkthrough

Walkthrough

The kernel build script configures expanded built-in virtio, container, networking, filesystem, security, and virtualization support. It tracks required and forbidden symbols and validates their resolved values after olddefconfig.

Changes

Virtio Linux kernel configuration

Layer / File(s) Summary
Configuration tracking and virtio support
packages/virtio-linux/build.sh		 The script keeps MODULES=y, disables module signing, records required and forbidden symbols through want() and nope(), and expands built-in virtio support with corrected symbols and dependencies.
Container and networking capabilities
packages/virtio-linux/build.sh		 The configuration adds namespaces, cgroup v2, process and syscall support, BPF prerequisites, tracing dependencies, and container networking features.
Storage, security, and virtualization support
packages/virtio-linux/build.sh		 The configuration adds block, filesystem, overlayfs, fanotify, security, LSM, and architecture-specific virtualization options.
Resolved configuration validation
packages/virtio-linux/build.sh		 After olddefconfig, the script reports required symbols that are missing, renamed, dependency-disabled, or modular. It also reports forbidden symbols that resolve to =y and exits with failure.

Estimated code review effort: 4 (Complex) | ~45 minutes

Suggested reviewers: msample, bryan-minimal

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main changes: adding CONFIG_PROC_CHILDREN and fixing broken virtio-linux kernel configurations.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch tom/kernel

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@twitchyliquid64
twitchyliquid64 added this pull request to the merge queue Aug 5, 2026
Merged via the queue into main with commit b1a1b1b Aug 5, 2026
10 checks passed
@twitchyliquid64
twitchyliquid64 deleted the tom/kernel branch August 5, 2026 04:57
@coderabbitai coderabbitai Bot mentioned this pull request Aug 5, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtnkminimal jtnkminimal jtnkminimal approved these changes
@msample msample Awaiting requested review from msample
@bryan-minimal bryan-minimal Awaiting requested review from bryan-minimal

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@twitchyliquid64 @jtnkminimal