Skip to content

Add maki 0.4.7 - #608

Merged
0chroma merged 3 commits into
mainfrom
add-maki
Aug 14, 2026
Merged

Add maki 0.4.7#608
0chroma merged 3 commits into
mainfrom
add-maki

Conversation

@0chroma

@0chroma 0chroma commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Add a package for maki 0.4.7, a Rust TUI AI coding agent (github.com/tontinton/maki).

Changes

File Purpose
packages/maki/build.ncl BuildSpec for maki 0.4.7: GitHub source tarball, rust + toolchain + make + perl build deps, glibc + libgcc runtime deps, standalone maki --version test
packages/maki/build.sh cargo build --release --locked --bin maki with Rust and C determinism flags (path remaps, prefix map)

Notes:

  • make and perl are required because isahc builds vendored OpenSSL from source (static-ssl). toolchain ships neither.
  • Built-in Lua plugins are embedded at compile time via include_dir!, so the package ships only the binary.
  • needs = { dns, internet } for cargo fetches; Cargo.lock is committed, so the build uses --locked.

Verification

  • mip check --packages maki: all 15 checks pass, including missing runtime_deps and the standalone test
  • Two clean-room builds (mip package build and mip package build --rebuild) produce byte-identical output (same content-addressed hash; diff -r clean)
  • maki --version prints maki 0.4.7

Install the sha256-pinned npm tarball instead of resolving
name@version at build time. The tarball ships npm-shrinkwrap.json,
which locks the transitive dependency tree; two --no-cache builds
produce identical content-addressed output. Addresses PR review.
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 8 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 31183d05-68d4-4198-a863-9c44f2048dbf

📥 Commits

Reviewing files that changed from the base of the PR and between 1cb30c6 and d00a7ea.

📒 Files selected for processing (4)
  • packages/maki/build.ncl
  • packages/maki/build.sh
  • packages/pi/build.ncl
  • packages/pi/build.sh

Comment @coderabbitai help to get the list of available commands.

@bryan-minimal bryan-minimal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0chroma
0chroma added this pull request to the merge queue Aug 14, 2026
Merged via the queue into main with commit fbf7663 Aug 14, 2026
10 checks passed
@0chroma
0chroma deleted the add-maki branch August 14, 2026 20:30
bryan-minimal added a commit that referenced this pull request Aug 14, 2026
…aming

The previous commit said tamarin "builds on arm64 and fails on amd64", and
treated it as the onboarding's amd64-unverified flag finally coming due. That
was wrong, and wrong in a way that would mislead the next reader.

pkgs#607 and #608 built the SAME tamarin source on the SAME amd64 builder and
passed — merged 20:28 and 20:30 on 2026-08-14, hours after #606 failed at
12:33. So amd64 works most of the time. It is not a miscompile, not a missing
dependency, and not something #606 introduced: it is a race, and #606 drew the
short straw.

This strengthens the fix rather than weakening it — removing cabal's own
store-provisioned alex removes the racy step — but the diagnosis in the comment
should say what is actually true.

Worth recording why a flake is the worse shape here: the natural response is to
re-run it, which usually works, which is exactly how one survives for weeks
without anyone fixing it. If this change does NOT settle it, the next suspect
is `--jobs=$(nproc)` itself rather than alex specifically, since the same race
can bite any build tool.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants