Skip to content

Basic swap sdk (inside Gomu sdk) that makes and takes orders, without orderbook - #7

Open
kainanaina wants to merge 3 commits into
mainfrom
swap-sdk
Open

Basic swap sdk (inside Gomu sdk) that makes and takes orders, without orderbook#7
kainanaina wants to merge 3 commits into
mainfrom
swap-sdk

Conversation

@kainanaina

Copy link
Copy Markdown
Contributor
  1. Add swapSdk to Gomu sdk.
  2. Add 2 new methods to Gomu sdk - makeSwapOrder (returns signed order) and takeSwapOrder (takes signed orders).
  3. Both new methods are currently not very useful without orderbook, so this PR can be frozen for a while.
  4. Also v3 SDK got method for cancelling orders, but I'm not sure what is the purpose of it, since people who manage order book can do a better job, without any gass fees.

@kainanaina
kainanaina requested a review from leeyikjiun June 9, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant