Trader fees - #16
Open
kainanaina wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds fees support to
makeOrderfor trader platform viamarketplacesConfigparam.Feecan either be{ recipient: string; amount: bigint }or{recipient: string; basisPoints: number }.Method
calculateFeesconverts all fees amounts to BigNumber string, and computes BigNumber amount forbasisPoints(amount * basisPoints / 10000). It properly asserts that no specific fee can be greater or equal to ERC20 amount, including the total fee value.After total fees are computed, they are subtracted from ERC20 amount to give us the final amount, because
nft-swap-sdkby default adds fees on top of the original amount, while we want fees to be part of the original price.https://github.com/trader-xyz/nft-swap-sdk/blob/main/src/sdk/v4/NftSwapV4.ts#L1146