Issue #1340 - Update cookie size requirements - #1563
Merged
Conversation
Collaborator
Author
|
(It feels easier to write tests against MUST vs SHOULD) |
Collaborator
Author
|
Actually, yeah. Let's do that. I'll update this PR. |
miketaylr
marked this pull request as ready for review
June 23, 2021 18:37
Collaborator
Author
|
PTAL @chlily1 |
chlily1
reviewed
Jun 23, 2021
chlily1
reviewed
Jun 24, 2021
chlily1
left a comment
Contributor
There was a problem hiding this comment.
Algorithm changes look good. Had a suggestion for the "Limits" section for clarity.
chlily1
reviewed
Jun 24, 2021
Contributor
|
Thanks! LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@chlily1 do you think we should move these requirements into the Set-Cookie parsing algorithm and make them
MUST NOTinstead ofSHOULD NOT? Or fine to leave as-is?