RFC6265bis: Prevent nameless cookies with prefixed values - #2251
Merged
Conversation
sbingler
requested review from
chlily1,
johnwilander and
mikewest
as code owners
September 21, 2022 22:20
mikewest
approved these changes
Sep 22, 2022
mikewest
left a comment
Member
There was a problem hiding this comment.
Given that we accept nameless cookies, this looks like a reasonable approach to me. We would ideally figure out how to stop accepting nameless cookies, but that's a larger effort. :)
Do we have tests for this behavior in WPT?
Collaborator
Author
Good question, no not yet. I'll add some. |
Collaborator
Author
|
Done |
Collaborator
Author
|
Ping @mikewest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify the cookie storage algorithm to reject cookies that:
As mentioned in #2229, malicious servers can exploit nameless cookies to impersonate prefix'd cookies.