Skip to content

feat(utils): add max reduction type - #4027

Merged
SunMarc merged 1 commit into
huggingface:mainfrom
imstevenpmwork:feat/add_max_compact
May 19, 2026
Merged

SunMarc merged 1 commit into
huggingface:mainfrom
imstevenpmwork:feat/add_max_compact

Conversation

@imstevenpmwork

@imstevenpmwork imstevenpmwork commented May 3, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

Extends reduce to accept max as a reduction type which will return the max of the input tensors

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@imstevenpmwork
imstevenpmwork marked this pull request as ready for review May 3, 2026 13:14
@imstevenpmwork

Copy link
Copy Markdown
Contributor Author

@SunMarc

@SunMarc SunMarc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! LGTM

@SunMarc
SunMarc merged commit cde3e58 into huggingface:main May 19, 2026
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants