Repository navigation
Fix gloo backend error in test_load_checkpoint_and_dispatch_with_broa… - #4056
Merged
Merged
Conversation
…dcast on XPU Signed-off-by: kaixuanliu <kaixuan.liu@intel.com>
Contributor
Author
|
@SunMarc pls help review, thx! |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
Author
|
The failed CI should not be introduced by this PR. Seems dependant transformers is not correctly installed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In test case:
tests/test_load_checkpoint_and_dispatch_with_broadcast.py::TestLoadCheckpointAndDispatchWithBroadcast::test_load_checkpoint_and_dispatch_ddpthe DDP test only registered xccl(using default backend), but DDP's logger requires a gloo backend on the PG (which xccl doesn't fall back to, unlike NCCL), so init now uses the hybrid
cpu:gloo,xpu:xccl— matching the FSDP setup already in state.py: L243