Repository navigation
Added a check in no_sync() to avoid errors when using deepspeed zero2/3 - #3656
Merged
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
kashif
pushed a commit
to kashif/accelerate
that referenced
this pull request
Jul 6, 2025
2 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a check in no_sync() to avoid errors when using deepspeed zero2/3
What does this PR do?
When using accelerate and deepspeed with zero2 or zero3, and setting the gradient accumulation > 1, an error will be reported:
AssertionError: no_sync context manager is incompatible with gradient partitioning logic of ZeRO stage 2Therefore, modify the
no_sync()function and add a judgment to it to ensure that no_sync does not conflict with the implementation of zero2 and zero3.Thanks @alisafaya
Fixes #3481
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@SunMarc @zach-huggingface