Repository navigation
Fix KMP_AFFINITY incorrectly set for non-CPU training - #3912
Merged
Merged
Conversation
The string "False" is truthy in Python, so `if current_env["ACCELERATE_USE_CPU"]:` always evaluates to True. Use parse_flag_from_env() for proper boolean parsing.
SunMarc
approved these changes
Jan 27, 2026
SunMarc
left a comment
Member
There was a problem hiding this comment.
Indeed, thanks for this fix !
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
2 of 5 tasks
SunMarc
added a commit
that referenced
this pull request
Sep 8, 2026
* Fix accelerate launch --cpu never setting the KMP variables #3912 gated KMP_AFFINITY and KMP_BLOCKTIME on CPU mode with: parse_flag_from_env(current_env["ACCELERATE_USE_CPU"], False) `parse_flag_from_env` takes an environment variable *name*, not a value, and does `os.environ.get(key, str(default))`. It is handed the string "True" or "False" here, looks for an environment variable by that name, does not find one and returns the default. The guard is therefore always False, so the two variables are never set, including for `accelerate launch --cpu`. Before #3912 the condition was `if current_env["ACCELERATE_USE_CPU"]:`, which was always True because "False" is a non-empty string, so KMP_AFFINITY was set on GPU launches too. That was the bug #3912 set out to fix; it swapped one constant for the other. Test the flag itself, the way the line above it already does, and drop the import that was added only for the broken call. * Update src/accelerate/utils/launch.py * Update src/accelerate/utils/launch.py --------- Co-authored-by: Marc Sun <57196510+SunMarc@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix for #3911
The string "False" is truthy in Python, so
if current_env["ACCELERATE_USE_CPU"]:always evaluates to True. Use parse_flag_from_env() for proper boolean parsing.