Skip to content

Fix Python 3.14 dict pickling compatibility - #8651

Open
FranciscoMaxwell wants to merge 1 commit into
huggingface:mainfrom
FranciscoMaxwell:fix-python-314-batch-setitems
Open

FranciscoMaxwell wants to merge 1 commit into
huggingface:mainfrom
FranciscoMaxwell:fix-python-314-batch-setitems

Conversation

@FranciscoMaxwell

Copy link
Copy Markdown

Closes #8373.

Summary

  • passes the new Python 3.14 _batch_setitems object argument when the custom datasets pickler is called through the old two-argument path
  • keeps the existing key sorting behavior for stable fingerprints
  • adds a regression test that simulates the Python 3.14 parent pickler signature

Validation

  • python -m compileall src\datasets\utils\_dill.py tests\test_fingerprint.py
  • git diff --check

I could not run pytest or ruff locally because they are not installed in this environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeError in _dill.py _batch_setitems with Python 3.14

1 participant