Repository navigation
Require peft>=0.17.0 and drop the target_parameters guards - #7640
Open
albertvillanova wants to merge 2 commits into
Open
albertvillanova wants to merge 2 commits into
albertvillanova wants to merge 2 commits into
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
6 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR raises the peft floor from 0.13.0 (September 2024) to 0.17.0 (August 2025) and removes the guards that floor made necessary.
Part of #7644.
Motivation
peft 0.13.0 is 24 months old, so under the criterion in #7116 it can be dropped without further justification. 0.17.0 is the newest release the same criterion allows today, since it is 14 months old and the rule does not require anything younger than 1 year.
LoraConfig.target_parameterswas introduced in peft 0.17.0, so everything #7119 added to keep 0.13 through 0.16 working becomes dead at this floor.Changes
peft>=0.13.0to>=0.17.0in thepeftextra and indevVersion("0.17.0") <=lower bound from the reference-adapter guard in the DPO, GRPO, KTO and RLOO trainers, and the comment sentence explaining ittarget_parameterstoLoraConfigdirectly inget_peft_configagain, instead of only when setrequire_peft_target_parameterstest mark and restore@require_pefton the six tests that used itThe
< Version("0.20.0")upper bound stays: it encodes peft#3340, fixed by peft#3350 in 0.20.0, and 0.17 to 0.19 are still supported.