Skip to content

fix(unsubscribe): one-click over https only, gated on dkim or sender - #596

Closed
hanthor wants to merge 2 commits into
hyprlab:mainfrom
tuna-os:fix/unsubscribe-https
Closed

hanthor wants to merge 2 commits into
hyprlab:mainfrom
tuna-os:fix/unsubscribe-https

Conversation

@hanthor

@hanthor hanthor commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

RFC 8058 one-click unsubscribe only allows https, and a POST should only fire for a header the sender actually vouched for.

  • The one-click POST is offered and sent only for https: handles; one_click_post refuses anything else too, which also covers stale cached verdicts.
  • It is kept only when a passing DKIM signature from the provider covers List-Unsubscribe in h= (and List-Unsubscribe-Post when present), or the sender verdict is neither Suspicious nor Fail. Otherwise the page opens in the browser instead. mailto: routes are unchanged; their confirm dialog already names the address.

Tests: the decision table (https only, DKIM coverage, verdicts) and dkim_covers.

RFC 8058 allows the POST to https handles only, and asks that a DKIM signature cover List-Unsubscribe. The one-click route is now kept only when the provider's passing DKIM signature lists the header in h=, or the sender check is neither suspicious nor failed; otherwise the list's page opens in the browser.
hyprlab added a commit that referenced this pull request Nov 7, 2026
RFC 8058 allows the POST to https handles only and asks that a DKIM signature cover List-Unsubscribe. The one-click route is kept only when the provider's passing DKIM signature lists the header in h=, or the sender check is neither suspicious nor failed; otherwise the list's page opens in the browser. Cache v23 takes the one-click handle off stored routes these rules would not offer it on.

Co-Authored-By: James Reilly <5840441+hanthor@users.noreply.github.com>
@hyprlab

hyprlab commented Nov 8, 2026

Copy link
Copy Markdown
Owner

Agentic reply:

Your one-click unsubscribe change is in the 1.48.0-beta.3 release, landed by hand and credited to you. At landing, the cache also drops the one-click route stored for messages that no longer qualify, so mail already read follows the new rule, and the translation files were regenerated rather than taken from the PR. Please test it there and report anything that doesn't look right. It reaches the stable channel with the next stable release.

The beta build is in the repo now. If you already have the beta installed, flatpak update picks it up. If not, download and install it first:

flatpak install --user --from https://hylki.hyprlab.co/flatpak/co.hyprlab.Hylki.Beta.flatpakref

RPM, Debian and AppImage betas: Beta channel.

@hyprlab hyprlab closed this Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants