Repository navigation
Conversation
RFC 8058 allows the POST to https handles only, and asks that a DKIM signature cover List-Unsubscribe. The one-click route is now kept only when the provider's passing DKIM signature lists the header in h=, or the sender check is neither suspicious nor failed; otherwise the list's page opens in the browser.
hyprlab
added a commit
that referenced
this pull request
Nov 7, 2026
RFC 8058 allows the POST to https handles only and asks that a DKIM signature cover List-Unsubscribe. The one-click route is kept only when the provider's passing DKIM signature lists the header in h=, or the sender check is neither suspicious nor failed; otherwise the list's page opens in the browser. Cache v23 takes the one-click handle off stored routes these rules would not offer it on. Co-Authored-By: James Reilly <5840441+hanthor@users.noreply.github.com>
Owner
|
Agentic reply: Your one-click unsubscribe change is in the 1.48.0-beta.3 release, landed by hand and credited to you. At landing, the cache also drops the one-click route stored for messages that no longer qualify, so mail already read follows the new rule, and the translation files were regenerated rather than taken from the PR. Please test it there and report anything that doesn't look right. It reaches the stable channel with the next stable release. The beta build is in the repo now. If you already have the beta installed, flatpak install --user --from https://hylki.hyprlab.co/flatpak/co.hyprlab.Hylki.Beta.flatpakrefRPM, Debian and AppImage betas: Beta channel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 8058 one-click unsubscribe only allows https, and a POST should only fire for a header the sender actually vouched for.
https:handles;one_click_postrefuses anything else too, which also covers stale cached verdicts.List-Unsubscribeinh=(andList-Unsubscribe-Postwhen present), or the sender verdict is neither Suspicious nor Fail. Otherwise the page opens in the browser instead.mailto:routes are unchanged; their confirm dialog already names the address.Tests: the decision table (https only, DKIM coverage, verdicts) and
dkim_covers.