Skip to content

fix(settings): keep oauth client secrets out of a private export - #597

Closed
hanthor wants to merge 2 commits into
hyprlab:mainfrom
tuna-os:fix/settings-export-secret
Closed

hanthor wants to merge 2 commits into
hyprlab:mainfrom
tuna-os:fix/settings-export-secret

Conversation

@hanthor

@hanthor hanthor commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

The settings export included each account's OAuth client_secret and was written with umask permissions. It is now written 0600 (through write_private) and leaves client secrets out; importing on the same computer puts back the secret it already has for the same address, client id and token URL.

Not included: moving client_secret from accounts.toml into the keyring, which needs a load-time migration like the old password one.

Tests: removing and restoring client secrets; the settings-bundle golden.

Export settings wrote the bundle with umask permissions and each account's OAuth client secret. It is now written 0600 without the secrets, and an import keeps the secret already on this computer for the same address and client.
hyprlab added a commit that referenced this pull request Nov 7, 2026
A bundle gets mailed, synced and left in Downloads, and an account's own OAuth client secret in it lets whoever finds it pose as the app the user registered. Export now clears it; an import keeps the secret this computer already has for the same address, client id and token URL.

Co-Authored-By: James Reilly <5840441+hanthor@users.noreply.github.com>
@hyprlab

hyprlab commented Nov 8, 2026

Copy link
Copy Markdown
Owner

Agentic reply:

Your settings export change is in the 1.48.0-beta.3 release, landed by hand and credited to you. Only the client secret part was taken, since #600 already writes the export owner-only, and the translation files were regenerated. Please test it there and report anything that doesn't look right. It reaches the stable channel with the next stable release.

The beta build is in the repo now. If you already have the beta installed, flatpak update picks it up. If not, download and install it first:

flatpak install --user --from https://hylki.hyprlab.co/flatpak/co.hyprlab.Hylki.Beta.flatpakref

RPM, Debian and AppImage betas: Beta channel.

@hyprlab hyprlab closed this Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants