Repository navigation
Improve Sort Operator (DYOD 2025) - #2720
Open
robert-oleynik wants to merge 186 commits into
Open
robert-oleynik wants to merge 186 commits into
robert-oleynik wants to merge 186 commits into
Conversation
…d fix out of bounds vector accesses (#2700) The update to gcc15 introduced some issues with the <ciso646> header, which is used by boost spinsort. It also introduced bounds checking for operator[] of vectors, which we violated. This PR fixes the issues caused by the upgrade to gcc15.
…roup2 into parallel-sort-operator
…d fix out of bounds vector accesses (#2700) The update to gcc15 introduced some issues with the <ciso646> header, which is used by boost spinsort. It also introduced bounds checking for operator[] of vectors, which we violated. This PR fixes the issues caused by the upgrade to gcc15.
…roup2 into parallel-sort-operator
Noel-Bastubbe
left a comment
There was a problem hiding this comment.
The IPS4O algorithm is hard to follow, but you did a good job of structuring the code and adding useful comments. You followed the hyrise coding conventions very well.
| if (last_stripe == stripe_ranges.end()) { | ||
| last_stripe = --stripe_ranges.end(); | ||
| } | ||
| DebugAssert(last_stripe != stripe_ranges.end(), "Bucket should end in last stripe"); |
There was a problem hiding this comment.
This DebugAssert in combination with the if-condition before looks unintuitive. How can last_strip and stripe_ranges.end() be equal at that point?
Collaborator
|
Can you please merge the master? It's needed for full CI runs as a node crashed on our side and it will take some time to get it back online. |
Bouncner
reviewed
Sep 19, 2025
Bouncner
left a comment
Collaborator
There was a problem hiding this comment.
Still haven't read all the code.
What would be help is a very brief high level description of IPSO. The paper has a very readable introduction of "buckets" and other terms.
Don't put too much effort in it, but a parapraph of the high level concept wiould be very helpful.
| if (column_info.nullable && segment_position.is_null()) { | ||
| *(normalized_key_start++) = normalized_null_value; | ||
| // Initialize actual key by setting all bytes to 0. | ||
| for (auto counter = size_t{0}; counter < column_info.width() - 1; ++counter) { |
| if (value.size() < STRING_CUTOFF) { | ||
| copy_uint_to_byte_array(normalized_key_start, uint64_t{0}, column_info.long_width); | ||
| } else { | ||
| const auto iter = std::ranges::lower_bound(column_info.long_strings, value); // NOLINT |
Collaborator
There was a problem hiding this comment.
Add the name of the silenced rule to NOLINT.
Co-authored-by: Bouncner <martin+github@boissier.de>
Bouncner
reviewed
Sep 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.