fix: clarify date error when metadata header is unclosed - #4253
Open
SSoggyTacoMan wants to merge 1 commit into
Open
SSoggyTacoMan wants to merge 1 commit into
SSoggyTacoMan wants to merge 1 commit into
Conversation
|
@SSoggyTacoMan is attempting to deploy a commit to the Hack Club Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When authors put code or instructions right below @addedOn without closing the comment block with */, the parser captures that extra text as part of the date. This triggers a confusing date format failure even when the date itself was valid.
This change checks if @addedOn contains newlines or trailing text, and provides an explicit error message telling the author to close the header with */.