Check if the output format is valid at the beginning - #71
Merged
Merged
Conversation
Contributor
Author
|
I still need to test if using an input and output folder still works, but I have to leave now. Other than that, this is finished. |
sezanzeb
marked this pull request as ready for review
May 31, 2024 09:04
sezanzeb
force-pushed
the
check-output-format
branch
from
May 31, 2024 10:27
3a4eb6a to
d370a98
Compare
Contributor
Author
|
@haoheliu this is ready for review |
Owner
|
Nice thanks for your effort! I will take a look on that! @sezanzeb |
Contributor
Author
|
small reminder |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Waiting for this to complete, just to realize that the output format was missing, was a bit frustrating. This checks if a file-extension is valid right at the start.
Other minor changes:
#!/usr/bin/env pythonI think it's really great that you provided a docker setup for this.