Skip to content

various: fix miscellaneous typos - #93

Merged
halostatue merged 1 commit into
halostatue:mainfrom
p-linnane:fix-various-typos
Feb 16, 2024
Merged

halostatue merged 1 commit into
halostatue:mainfrom
p-linnane:fix-various-typos

Conversation

@p-linnane

Copy link
Copy Markdown
Contributor

This PR aims to fix various minor typos across the codebase. I noticed some of these when doing the same review on our Homebrew/brew repo, since we use diff-lcs.

@halostatue halostatue left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the second, I think I would rather change it to indexes. While indices is absolutely the correct word, I think that indexes will be more understandable to all readers.

Can you also make the following changes:

  • History.md: Add a short one sentence description of the change here. Remember to include the reference to this PR [#93][] and the appropriate reference link at the bottom of the document.
  • Contributing.md: please add your name to the contributor list.

Once those changes are done, I see no reason not to merge this.

Just as an amusing factoid, the PR title has a typo in it, too.

Signed-off-by: Patrick Linnane <patrick@linnane.io>
@p-linnane p-linnane changed the title various: fix miscellanous typos various: fix miscellaneous typos Feb 16, 2024
@p-linnane

Copy link
Copy Markdown
Contributor Author

Changes made as requested. And fixed my own typo as well 😄.

@halostatue
halostatue enabled auto-merge (rebase) February 16, 2024 15:40
@halostatue

Copy link
Copy Markdown
Owner

These changes aren't enough to trigger a release, but they will be included in the next one. Thank you for your contribution!

@halostatue
halostatue merged commit f7a08c6 into halostatue:main Feb 16, 2024
@p-linnane
p-linnane deleted the fix-various-typos branch February 16, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants