Conversation
…es (or '*' is allowed)
Contributor
|
This is not the right solution given that it is a breaking change. However, I think I can accommodate the use case. |
Author
|
Yep, for sure. I don't need the specific change, just the end result. Thanks! Sent from my Windows Phone -----Original Message----- This is not the right solution given that it is a breaking change. However, I think I can accommodate the use case. |
jmonster
pushed a commit
to jmonster/hapi
that referenced
this pull request
Feb 10, 2014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't necessarily want to make known which origins are allowed for a private service. I could see allowing '*' to always be sent as a sign that this is a public service so this diff might not be the perfect (ish) solution.