add ability to listen on unix domain socket - #1123

I don't like adding a new config value for this. I think we can use the host argument by simply checking it for the presence of '/' since hostnames can't include that character and a unix domain socket path must.

That sounds like a good idea, I hadn't thought of that. It makes sense to do that since the two are both strings and only one form can be used at a time.

I can rework the change to repurpose hostname when wanting to use a unix domain socket. I will try to get that updated tomorrow morning and resubmitted.

Thanks!

@hueniverse I have reimplemented this using the premise that if host contains a '/' it implies a unix domain socket.

See if this is acceptable or whether it needs additional work.

Thanks!

Thanks for merging this in Eran!

Awesome work @jeffbski this is awesome.

One situation we're running into is in dev, we supply a host of '127.0.0.1' and port of 8000 and on production we'd like to be able to supply a host of '/var/www/app/shared/app.sock'. Everything is fine up to this point :) BUT we use the hapi cli and our manifest servers attr looks like

"servers": [{host: "$env.HOST", port: "$env.PORT"}]

This will not work in prod when HOST is a socket as we can't supply a port due to https://github.com/spumko/hapi/blob/master/lib/server.js#L71

Feels like instead of erroring we should be just dropping the port.

Thoughts @jeffbski @hueniverse ?

Open an issue and I'll think about it.