Skip to content

Increasing allowed sockets to 10 for client - #850

Merged
hueniverse merged 8 commits into
hapijs:proxyfrom
geek:proxy
May 13, 2013
Merged

hueniverse merged 8 commits into
hapijs:proxyfrom
geek:proxy

Conversation

@geek

@geek geek commented May 13, 2013

Copy link
Copy Markdown
Member

No description provided.

Comment thread lib/client.js Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this for?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since write only supports string or buffer, thought it made since to prevent other payload types from being written

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should validate payload at the top with an assert.

Comment thread lib/defaults.js Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default to 0 or null which means leave node alone. Also, move this next to the tls section.

hueniverse pushed a commit that referenced this pull request May 13, 2013
Increasing allowed sockets to 10 for client
@hueniverse
hueniverse merged commit 00d15bd into hapijs:proxy May 13, 2013
jmonster pushed a commit to jmonster/hapi that referenced this pull request Feb 10, 2014
Increasing allowed sockets to 10 for client
@lock lock Bot locked as resolved and limited conversation to collaborators Jan 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants