Skip to content

Proxy requests are closed when server response already sent - #906

Merged
hueniverse merged 3 commits into
hapijs:masterfrom
geek:master
May 31, 2013
Merged

hueniverse merged 3 commits into
hapijs:masterfrom
geek:master

Conversation

@geek

@geek geek commented May 31, 2013

Copy link
Copy Markdown
Member

No description provided.

Comment thread lib/client.js Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this for?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will remove any socket timeout listeners (https://github.com/joyent/node/blob/v0.10.9-release/lib/net.js#L315).

Comment thread lib/client.js Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need this since request._reply will clean it up.

hueniverse pushed a commit that referenced this pull request May 31, 2013
Proxy requests are closed when server response already sent
@hueniverse
hueniverse merged commit 2912e22 into hapijs:master May 31, 2013
jmonster pushed a commit to jmonster/hapi that referenced this pull request Feb 10, 2014
Proxy requests are closed when server response already sent
@lock lock Bot locked as resolved and limited conversation to collaborators Jan 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants