Repository navigation
GHC 9 Support - #392
Merged
Merged
GHC 9 Support#392
Conversation
Using * alias for Data.Kind.Type is being deprecated, and from GHC 9.0 it requires another language extension (`StarIsType`).
This version of TH comes with an API change where the return type of the typed splices are wrapped with a type called `Code`. Unfortunately, this requires conditional compilation. Details: https://gitlab.haskell.org/ghc/ghc/-/commit/a625719284db7c69fa3d122e829291a16960e85f
|
With GHC-9.0.1 released it would be great if this PR could be merged. |
Member
|
Thank you, @utdemir, we apologize for the radio silence. This should be out on the next release (coming soon) 🚀 |
moodmosaic
reviewed
Feb 8, 2021
moodmosaic
left a comment
Member
There was a problem hiding this comment.
👍 /cc co-reviewed @jacobstanley
6 tasks done
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes Hedgehog compile with the current GHC development branch (soon to be GHC 9). It only required two minor changes on hedgehog side:
Data.Kind.Typeinstead of*See the commit messages for a bit more details.
These changes should be enough from the hedgehog side, but even after these:
--allow-newerflag has to be passed sinceprimitivehas an overly restrictive upper bound onbase.QuickCheckdoes not compile yet, sohedgehog-quickcheckdoes not work yet.I tried to keep the changes as small as possible while maintaining the backwards compatibility, however I did only check with GHC 8.10 and GHC 9. Let me know if there is anything else I should do to get it compatible with even older GHC versions.